Adding if statement to an existing while loop

Question

I have to do add an if statement to my while loop.
When I write ./scriptname 1, it executes my while loop.
When I instead write ./scriptname hello, it still executes my while loop.
What I want it to do is echo "no" if I add letters after ./scriptname but execute the while loop if I add numbers after ./scriptname.
Does anyone know what I have done wrong in the script attached?

bac0n · Answer

Its a good practice to keep your if-then-statement as short as possible, this way you dont need the else statement.

#!/bin/bash

x=$1
y=$2

if [[ $x =~ (^$|[^0-9]) ]]; then
    echo "no"
    exit 0
fi
while (( $x <= 3 )); do
    echo "$x $y"
    ((x++))
    sleep 5
done

Or with a for-loop:

for ((z=3; $x<=$z; x++)); do
    echo "$x $y"
    sleep 5
done

Adding if statement to an existing while loop

One Answer

Add your own answers!

Ask a Question